Re: [PATCH v3 00/14] add ecspi ERR009165 for i.mx6/7 soc family

[Lucas Stach]

Hi Robin,

Am Dienstag, den 07.05.2019, 09:15 +0000 schrieb Robin Gong:
> Â There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO
> transfer to be send twice in DMA mode. Please get more information from:
> https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding
> new sdma ram script which works in XCHÂÂmode as PIO inside sdma instead
> of SMC mode, meanwhile, 'TX_THRESHOLD' should be 0. The issue should be
> exist on all legacy i.mx6/7 soc family before i.mx6ul.
> NXP fix this design issue from i.mx6ul, so newer chips including i.mx6ul/
> 6ull/6sll do not need this workaroud anymore. All other i.mx6/7/8 chips
> still need this workaroud. This patch set add new 'fsl,imx6ul-ecspi'
> for ecspi driver and 'ecspi_fixed' in sdma driver to choose if need errata
> or not.
> Â The first two reverted patches should be the same issue, though, it
> seems 'fixed' by changing to other shp script. Hope Sean or Sascha could
> have the chance to test this patch set if could fix their issues.
> Â Besides, enable sdma support for i.mx8mm/8mq and fix ecspi1 not work
> on i.mx8mm because the event id is zero.
> 
> PS:
> Â Please get sdma firmware from below linux-firmware and copy it to your
> local rootfs /lib/firmware/imx/sdma.
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/imx/sdma

This series is unfit for merging, as long as it depends on a SDMA RAM
script that is known to break serial DMA. When can we expect to get a
firmware version with the broken serial script removed out into the
public?

Regards,
Lucas

> v2:
> Â 1. add commit log for reverted patches.
> Â 2. add comment for 'ecspi_fixed' in sdma driver.
> Â 3. add 'fsl,imx6sll-ecspi' compatible instead of 'fsl,imx6ul-ecspi'
> ÂÂÂÂÂrather than remove.
> v3:
> Â 1. confirm with design team make sure ERR009165 fixed on i.mx6ul/i.mx6ull
> Â /i.mx6sll, not fixed on i.mx8m/8mm and other i.mx6/7 legacy chips.
> Â Correct dts related dts patch in v2.
> Â 2. clean eratta information in binding doc and new 'tx_glitch_fixed' flag
> Â in spi-imx driver to state ERR009165 fixed or not.
> Â 3. Enlarge burst size to fifo size for tx since tx_wml set to 0 in the
> Â errata workaroud, thus improve performance as possible.
> 
> Robin Gong (14):
> Â Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"
> Â Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"
> Â Revert "dmaengine: imx-sdma: refine to load context only once"
> Â dmaengine: imx-sdma: remove dupilicated sdma_load_context
> Â dmaengine: imx-sdma: add mcu_2_ecspi script
> Â spi: imx: fix ERR009165
> Â spi: imx: remove ERR009165 workaround on i.mx6ul
> Â dt-bindings: spi: imx: add new i.mx6ul compatible name
> Â dmaengine: imx-sdma: remove ERR009165 on i.mx6ul
> Â dt-bindings: dma: imx-sdma: add i.mx6ul/6sx compatible name
> Â dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm
> Â ARM: dts: imx6ul: add dma support on ecspi
> Â ARM: dts: imx6sll: correct sdma compatible
> Â arm64: defconfig: Enable SDMA on i.mx8mq/8mm
> 
> Â.../devicetree/bindings/dma/fsl-imx-sdma.txtÂÂÂÂÂÂÂ|ÂÂ2 +
> Â.../devicetree/bindings/spi/fsl-imx-cspi.txtÂÂÂÂÂÂÂ|ÂÂ1 +
> Âarch/arm/boot/dts/imx6q.dtsiÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ2 +-
> Âarch/arm/boot/dts/imx6qdl.dtsiÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ8 +--
> Âarch/arm/boot/dts/imx6sll.dtsiÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ2 +-
> Âarch/arm/boot/dts/imx6ul.dtsiÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ8 +++
> Âarch/arm64/configs/defconfigÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ|ÂÂ3 +
> Âdrivers/dma/imx-sdma.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 78 ++++++++++++++++------
> Âdrivers/spi/spi-imx.cÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ| 61 ++++++++++++++---
> Âinclude/linux/platform_data/dma-imx-sdma.hÂÂÂÂÂÂÂÂÂ|ÂÂ1 +
> Â10 files changed, 132 insertions(+), 34 deletions(-)
> 
> --Â
> 2.7.4
>