Re: [PATCH 2/5] Coccinelle: put_device: Add a cast to an expression for an assignment
From: Julia Lawall
Date: Mon May 13 2019 - 05:35:05 EST
On Mon, 13 May 2019, Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, 8 May 2019 13:50:49 +0200
>
> Extend a when constraint in a SmPL rule so that an additional cast
> is optionally excluded from source code searches for an expression
> in assignments.
Acked-by: Julia Lawall <julia.lawall@xxxxxxx>
>
> Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Suggested-by: Julia Lawall <Julia.Lawall@xxxxxxx>
> Link: https://lore.kernel.org/lkml/alpine.DEB.2.21.1902160934400.3212@hadrien/
> Link: https://systeme.lip6.fr/pipermail/cocci/2019-February/005592.html
> ---
> scripts/coccinelle/free/put_device.cocci | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/coccinelle/free/put_device.cocci b/scripts/coccinelle/free/put_device.cocci
> index 3ebebc064f10..120921366e84 100644
> --- a/scripts/coccinelle/free/put_device.cocci
> +++ b/scripts/coccinelle/free/put_device.cocci
> @@ -24,7 +24,7 @@ if (id == NULL || ...) { ... return ...; }
> when != of_dev_put(id)
> when != if (id) { ... put_device(&id->dev) ... }
> when != e1 = (T)id
> - when != e1 = &id->dev
> + when != e1 = (T)(&id->dev)
> when != e1 = get_device(&id->dev)
> when != e1 = (T1)platform_get_drvdata(id)
> (
> --
> 2.21.0
>
>