Re: [PATCH 0/5] mm/hmm: HMM documentation updates and code fixes

From: Ralph Campbell
Date: Mon May 13 2019 - 13:28:47 EST




On 5/12/19 8:08 AM, Jerome Glisse wrote:
On Mon, May 06, 2019 at 04:29:37PM -0700, rcampbell@xxxxxxxxxx wrote:
From: Ralph Campbell <rcampbell@xxxxxxxxxx>

I hit a use after free bug in hmm_free() with KASAN and then couldn't
stop myself from cleaning up a bunch of documentation and coding style
changes. So the first two patches are clean ups, the last three are
the fixes.

Ralph Campbell (5):
mm/hmm: Update HMM documentation
mm/hmm: Clean up some coding style and comments
mm/hmm: Use mm_get_hmm() in hmm_range_register()
mm/hmm: hmm_vma_fault() doesn't always call hmm_range_unregister()
mm/hmm: Fix mm stale reference use in hmm_free()

This patchset does not seems to be on top of
https://cgit.freedesktop.org/~glisse/linux/log/?h=hmm-5.2-v3

So here we are out of sync, on documentation and code. If you
have any fix for https://cgit.freedesktop.org/~glisse/linux/log/?h=hmm-5.2-v3
then please submit something on top of that.

Cheers,
JÃrÃme


Documentation/vm/hmm.rst | 139 ++++++++++++++++++-----------------
include/linux/hmm.h | 84 ++++++++++------------
mm/hmm.c | 151 ++++++++++++++++-----------------------
3 files changed, 174 insertions(+), 200 deletions(-)

--
2.20.1

The patches are based on top of Andrew's mmotm tree
git://git.cmpxchg.org/linux-mmotm.git v5.1-rc6-mmotm-2019-04-25-16-30.
They apply cleanly to that git tag as well as your hmm-5.2-v3 branch
so I guess I am confused where we are out of sync.