Re: [PATCH 2/2] ARM: dts: vf610-zii-dev: Add QSPI node

[Andrey Smirnov]

On Mon, May 13, 2019 at 5:15 AM Fabio Estevam <festevam@xxxxxxxxx> wrote:
>
> Hi Andrey,
>
> On Mon, May 13, 2019 at 12:59 AM Andrey Smirnov
> <andrew.smirnov@xxxxxxxxx> wrote:
>
> > +&qspi0 {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_qspi0>;
> > +       status = "okay";
> > +
> > +       /*
> > +        * Attached MT25QL02 can go up to 90Mhz in DTR and 166 in SDR
> > +        * modes, so we limit spi-max-frequency to 90Mhz
>
> Nit: It is MHz, not Mhz.
>
> MT25QL02 datasheet refers to DTR and STR (not SDR).
>

Sure, will fix.

> Also, the public datasheet I can see online lists these limits differently:
>
> "â Clock frequency â 133 MHz (MAX) for all protocols in STR â 66 MHz
> (MAX) for all protocols in DTR"

Here's the datasheet I got those numbers from:

https://www.micron.com/-/media/client/global/documents/products/data-sheet/nor-flash/serial-nor/mt25q/die-rev-b/mt25q_qlkt_u_02g_cbb_0.pdf

Thanks,
Andrey Smirnov