Re: [PATCH] perf vendor events intel: Add uncore_upi JSON support

From: Arnaldo Carvalho de Melo
Date: Mon May 13 2019 - 18:07:53 EST


On May 13, 2019 6:29:30 PM GMT-03:00, "Liang, Kan" <kan.liang@xxxxxxxxxxxxxxx> wrote:
>Hi Arnaldo,
>
>Could you please apply this fix?

I think I merged this today, will check.

Thanks

- Arnaldo
>
>Thanks,
>Kan
>
>On 5/7/2019 9:16 AM, kan.liang@xxxxxxxxxxxxxxx wrote:
>> From: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
>>
>> Perf cannot parse UPI events.
>>
>> #perf stat -e UPI_DATA_BANDWIDTH_TX
>> event syntax error: 'UPI_DATA_BANDWIDTH_TX'
>> \___ parser error
>> Run 'perf list' for a list of valid events
>>
>> The JSON lists call the box UPI LL, while perf calls it upi.
>> Add conversion support to json to convert the unit properly.
>>
>> Signed-off-by: Kan Liang <kan.liang@xxxxxxxxxxxxxxx>
>> ---
>> tools/perf/pmu-events/jevents.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/perf/pmu-events/jevents.c
>b/tools/perf/pmu-events/jevents.c
>> index 68c92bb..daaea50 100644
>> --- a/tools/perf/pmu-events/jevents.c
>> +++ b/tools/perf/pmu-events/jevents.c
>> @@ -235,6 +235,7 @@ static struct map {
>> { "iMPH-U", "uncore_arb" },
>> { "CPU-M-CF", "cpum_cf" },
>> { "CPU-M-SF", "cpum_sf" },
>> + { "UPI LL", "uncore_upi" },
>> {}
>> };
>>
>>