Re: [PATCH 3/3] LICENSES: Rename other to deprecated

From: Borislav Petkov
Date: Tue May 14 2019 - 06:28:18 EST


On Tue, Apr 30, 2019 at 06:51:30AM -0400, Christoph Hellwig wrote:
> Make it clear in the directory name that these are not intended for new
> code.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> ---
> Documentation/process/license-rules.rst | 8 ++++----
> LICENSES/{other => deprecated}/GPL-1.0 | 0
> LICENSES/{other => deprecated}/ISC | 0
> LICENSES/{other => deprecated}/Linux-OpenIB | 0
> LICENSES/{other => deprecated}/X11 | 0
> 5 files changed, 4 insertions(+), 4 deletions(-)
> rename LICENSES/{other => deprecated}/GPL-1.0 (100%)
> rename LICENSES/{other => deprecated}/ISC (100%)
> rename LICENSES/{other => deprecated}/Linux-OpenIB (100%)
> rename LICENSES/{other => deprecated}/X11 (100%)

This breaks scripts/spdxcheck.py, it needs below hunk. Also, should
"dual" be added to license_dirs too?

diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py
index 4fe392e507fb..1a39b34588b7 100755
--- a/scripts/spdxcheck.py
+++ b/scripts/spdxcheck.py
@@ -32,7 +32,7 @@ class SPDXdata(object):
def read_spdxdata(repo):

# The subdirectories of LICENSES in the kernel source
- license_dirs = [ "preferred", "other", "exceptions" ]
+ license_dirs = [ "preferred", "deprecated", "exceptions" ]
lictree = repo.head.commit.tree['LICENSES']

spdx = SPDXdata()

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.