Re: [RFC PATCH] ARM: mach-shmobile: Parse DT to get ARCH timer memory region

From: Oleksandr
Date: Tue May 14 2019 - 10:00:32 EST



On 14.05.19 10:16, Geert Uytterhoeven wrote:
Hi Oleksandr,

Hi Geert



On Mon, May 13, 2019 at 6:00 PM Oleksandr <olekstysh@xxxxxxxxx> wrote:
On 13.05.19 18:13, Geert Uytterhoeven wrote:
So, if the DT bindings for the counter module is not an option (if I
correctly understood a discussion pointed by Geert in another letter),
we should probably prevent all timer code here from being executed if
PSCI is in use.
What I mean is to return to [2], but with the modification to use
psci_smp_available() helper as an indicator of PSCI usage.

Julien, Geert, what do you think?
Yes, that sounds good to me.

Note that psci_smp_available() seems to return false if CONFIG_SMP=n,
so checking for that is not sufficient to avoid crashes when running a
uniprocessor kernel on a PSCI-enabled system.
Indeed, you are right.


Nothing than just check for psci_ops.cpu_on == NULL directly comes to
mind...

Have already checked with CONFIG_SMP=n, it works.

Sounds ok?
Fine for me, thanks!

Great, I will send new version.



Gr{oetje,eeting}s,

Geert

--
Regards,

Oleksandr Tyshchenko