[PATCH] drm/i915: drop unneeded -Wall addition
From: Masahiro Yamada
Date: Wed May 15 2019 - 00:53:45 EST
The top level Makefile adds -Wall globally:
KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \
I see two "-Wall" added for compiling under drivers/gpu/drm/i915/.
Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
---
BTW, I have a question in the comment:
"Note the danger in using -Wall -Wextra is that when CI updates gcc we
will most likely get a sudden build breakage... Hopefully we will fix
new warnings before CI updates!"
Enabling whatever warning options does not cause build breakage.
-Werror does.
So, I think the correct statement is:
"Note the danger in using -Werror is that when CI updates gcc we ...
^^^^^^^
drivers/gpu/drm/i915/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/drm/i915/Makefile
index fbcb0904f4a8..4a4f60c7edfc 100644
--- a/drivers/gpu/drm/i915/Makefile
+++ b/drivers/gpu/drm/i915/Makefile
@@ -12,7 +12,7 @@
# Note the danger in using -Wall -Wextra is that when CI updates gcc we
# will most likely get a sudden build breakage... Hopefully we will fix
# new warnings before CI updates!
-subdir-ccflags-y := -Wall -Wextra
+subdir-ccflags-y := -Wextra
subdir-ccflags-y += $(call cc-disable-warning, unused-parameter)
subdir-ccflags-y += $(call cc-disable-warning, type-limits)
subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
--
2.17.1