Re: [2/3] Coccinelle: pci_free_consistent: Reduce a bit of duplicate SmPL code

From: Julia Lawall
Date: Wed May 15 2019 - 02:13:07 EST




On Wed, 15 May 2019, Markus Elfring wrote:

> >> A return statement was specified with a known value for three branches
> >> of a SmPL disjunction.
> >> Reduce duplicate SmPL code there by using another disjunction for
> >> these return values.
> â
> > NACK. The goak is not to squeeze the most information into the fewest
> > number of characters.
>
> Can you accept any other formatting for the adjusted SmPL code?

No. It's fine as is.

>
>
> > The rule was fine as it was.
>
> Can different run time characteristics become relevant here?

No.

julia