Re: [PATCH 18/18] arm64: defconfig: enable build of IPA code

From: Alex Elder
Date: Wed May 15 2019 - 08:51:16 EST


On 5/15/19 3:23 AM, Arnd Bergmann wrote:
> On Sun, May 12, 2019 at 3:25 AM Alex Elder <elder@xxxxxxxxxx> wrote:
>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 2d9c39033c1a..4f4d803e563d 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -268,6 +268,7 @@ CONFIG_SMSC911X=y
>> CONFIG_SNI_AVE=y
>> CONFIG_SNI_NETSEC=y
>> CONFIG_STMMAC_ETH=m
>> +CONFIG_IPA=y
>> CONFIG_MDIO_BUS_MUX_MMIOREG=y
>> CONFIG_AT803X_PHY=m
>> CONFIG_MARVELL_PHY=m
>
> Since the device is not needed for booting, please make this
> CONFIG_IPA=m instead to keep the kernel image a little smaller.
>
> Arnd
>

Oops, yes, that was my intention but I forgot to fix that
before I sent it out. This code works as a module, but
in order to make the whole system allow the module to be both
removed and re-inserted safely, I need some work to be done
on the modem end and that's beyond my direct control. I have
been testing with it as a kernel built-in driver in the mean
time.

In any case, it is my intention to have it be normally built
as a module and I will ensure that when I send out future
revisions of this series.

-Alex