Re: [PATCH 00/18] net: introduce Qualcomm IPA driver

[Alex Elder]

On 5/15/19 7:37 AM, Arnd Bergmann wrote:
> On Sun, May 12, 2019 at 3:25 AM Alex Elder <elder@xxxxxxxxxx> wrote:
>>
>> A version of this code was posted in November 2018 as an RFC.
>>   https://lore.kernel.org/lkml/20181107003250.5832-1-elder@xxxxxxxxxx/
>> Fixes addressing all feedback received have been implemented.  It
>> has undergone considerable further rework since that time, and
>> most of the "future work" described then has now been completed.
> 
> I think this has turned out really well now.  I've gone through the patches
> today and not found any real show-stoppers, but replied with a couple of
> minor things I noticed.
> 
> I think it's probably worth rearranging the rx and tx code to avoid
> the spinlocks, which would be the main optimization I can still
> think of to reduce the coherency traffic.

Arnd I appreciate your review *so* much.  You clearly committed
a significant block of time to this and your comments were very
insightful and focused.  I concur with everything you pointed
out and will address all of your concerns when I send out v2
of the series.

Thank you for your careful review.

					-Alex

> 
>        Arnd
>