Re: [PATCH v2 1/1] bsr: do not use assignment in if condition

From: Greg KH
Date: Wed May 15 2019 - 11:16:27 EST


On Wed, May 15, 2019 at 08:39:52PM +0530, parna.naveenkumar@xxxxxxxxx wrote:
> From: Naveen Kumar Parna <parna.naveenkumar@xxxxxxxxx>
>
> checkpatch.pl does not like assignment in if condition
>
> Signed-off-by: Naveen Kumar Parna <parna.naveenkumar@xxxxxxxxx>
> ---
> drivers/char/bsr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

If you do a v2, you always have to show below the --- line what changed
from the previous version.

v3? :)

thanks,

greg k-h