Re: [PATCH] x86/build: Move _etext to actual end of .text
From: Kees Cook
Date: Wed May 15 2019 - 14:56:36 EST
On Tue, May 14, 2019 at 06:10:55PM +0200, Johannes Hirte wrote:
> On 2019 Mai 14, Kees Cook wrote:
> > On Tue, May 14, 2019 at 02:04:21PM +0200, Johannes Hirte wrote:
> > > This breaks the build on my system:
> > >
> > > RELOCS arch/x86/boot/compressed/vmlinux.relocs
> > > CC arch/x86/boot/compressed/early_serial_console.o
> > > CC arch/x86/boot/compressed/kaslr.o
> > > AS arch/x86/boot/compressed/mem_encrypt.o
> > > CC arch/x86/boot/compressed/kaslr_64.o
> > > Invalid absolute R_X86_64_32S relocation: _etext
> > > make[2]: *** [arch/x86/boot/compressed/Makefile:130: arch/x86/boot/compressed/vmlinux.relocs] Error 1
> > > make[2]: *** Deleting file 'arch/x86/boot/compressed/vmlinux.relocs'
> > > make[2]: *** Waiting for unfinished jobs....
> > > make[1]: *** [arch/x86/boot/Makefile:112: arch/x86/boot/compressed/vmlinux] Error 2
> > > make: *** [arch/x86/Makefile:283: bzImage] Error 2
> >
> > Interesting! Can you send along your .config and compiler details?
>
> Tested with gcc-8.3 and gcc-9.1, both the same result.
> [...]
> gcc version 8.3.0 (Gentoo 8.3.0-r1 p1.1)
Hm, I'm not able to reproduce this with any of the compilers I have
access to. The most recent I have is:
gcc (Ubuntu 20180425-1ubuntu1) 9.0.0 20180425 (experimental) [trunk revision 259645]
Various stupid questions: did you wipe the whole bulid tree and start
clean? Is this specific to Gentoo's compiler package?
I'll see if I can spin up a Gentoo image...
--
Kees Cook