Re: [RESEND PATCH] nvdimm: fix some compilation warnings

[Qian Cai]

>>                }
>> 
>> diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
>> index 7ff684159f29..2eb6a6cfe9e4 100644
>> --- a/drivers/nvdimm/bus.c
>> +++ b/drivers/nvdimm/bus.c
>> @@ -642,7 +642,7 @@ static struct attribute *nd_device_attributes[] = {
>>        NULL,
>> };
>> 
>> -/**
>> +/*
>>  * nd_device_attribute_group - generic attributes for all devices on an nd bus
>>  */
>> struct attribute_group nd_device_attribute_group = {
>> @@ -671,7 +671,7 @@ static umode_t nd_numa_attr_visible(struct kobject *kobj, struct attribute *a,
>>        return a->mode;
>> }
>> 
>> -/**
>> +/*
>>  * nd_numa_attribute_group - NUMA attributes for all devices on an nd bus
>>  */
> 
> Lets just fix this to be a valid kernel-doc format for a struct.
> 
> @@ -672,7 +672,7 @@ static umode_t nd_numa_attr_visible(struct kobject
> *kobj, struct attribute *a,
> }
> 
> /**
> - * nd_numa_attribute_group - NUMA attributes for all devices on an nd bus
> + * struct nd_numa_attribute_group - NUMA attributes for all devices
> on an nd bus
>  */
> struct attribute_group nd_numa_attribute_group = {
>        .attrs = nd_numa_attributes,

This wonât work because kernel-doc is to explain a struct definition, but this is a just an assignment.
The "struct attribute_groupâ kernel-doc is in include/linux/sysfs.h.