Re: [PATCH] tracing: Kernel access to Ftrace instances

[Steven Rostedt]

On May 15, 2019 8:05:29 PM PDT, Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:
>
>> >> diff --git a/kernel/trace/trace_events.c
>b/kernel/trace/trace_events.c
>> >> index 5b3b0c3..81c038e 100644
>> >> --- a/kernel/trace/trace_events.c
>> >> +++ b/kernel/trace/trace_events.c
>> >> @@ -832,6 +832,7 @@ static int ftrace_set_clr_event(struct
>trace_array *tr, char *buf, int set)
>> >>   
>> >>   	return ret;
>> >>   }
>> >> +EXPORT_SYMBOL_GPL(ftrace_set_clr_event);
>> > I found this exports a static function to module. Did it work?
>> 
>> I had tested the changes with my module. This change to static was
>added 
>> in the test patch, but somehow missed it in the final patch that was 
>> sent out.
>
>If you can send some example module patch under samples/, that is more
>helpful for us to check it. And it is possible to use in kselftest too.
>
>> 
>> Will send a new patch along with a few additional ones to add some
>NULL 
>> checks to ensure safe usage by modules and add the APIs to a header
>file 
>> that can be used by the modules.
>
>It seems your's already in Steve's ftrace/core branch, so I think you
>can make
>additional patch to fix it. Steve, is that OK?
>

Yes. In fact I already sent a pull request to Linus.  Please send a patch on top of my ftrace/core branch.


Thanks,

-- Steve

>Thank you,
>
>> 
>> Thanks,
>> 
>> Divya
>> 
>> >
>> > Thank you,
>> >

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity and top posting.