Re: [PATCH] staging: rtl8723bs: core: rtw_recv: fix warning Comparison to NULL

[Dan Carpenter]

On Wed, May 15, 2019 at 11:15:36PM +0530, Hariprasad Kelam wrote:
> @@ -1042,7 +1042,7 @@ sint sta2ap_data_frame(
>  		}
>  
>  		*psta = rtw_get_stainfo(pstapriv, pattrib->src);
> -		if (*psta == NULL) {
> +		if (!*psta == NULL) {
                    ^^^^^^^^^^^^^^
It's surprising that this didn't cause some kind of warning somewhere...

>  			RT_TRACE(_module_rtl871x_recv_c_, _drv_err_, ("can't get psta under AP_MODE; drop pkt\n"));
>  			DBG_871X("issue_deauth to sta =" MAC_FMT " for the reason(7)\n", MAC_ARG(pattrib->src));
>  

regards,
dan carpenter