Re: INFO: task hung in __get_super
From: Jan Kara
Date: Thu May 16 2019 - 08:34:01 EST
On Thu 16-05-19 21:17:14, Tetsuo Handa wrote:
> On 2019/05/16 20:48, Jan Kara wrote:
> > OK, so non-racy fix was a bit more involved and I've ended up just
> > upgrading the file reference to an exclusive one in loop_set_fd() instead
> > of trying to hand-craft some locking solution. The result is attached and
> > it passes blktests.
>
> blkdev_get() has corresponding blkdev_put().
> bdgrab() does not have corresponding bdput() ?
Yes, and that's hidden inside blkdev_put() (or failing blkdev_get()). Don't
get me started on calling conventions of these functions... I've wasted half
an hour trying to figure out where I'm leaking inode references in my patch
;).
Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR