Re: [PATCH v2 1/3] dt-bindings: gpu: add #cooling-cells property to the ARM Mali Midgard GPU binding
From: Doug Anderson
Date: Thu May 16 2019 - 13:42:58 EST
Hi,
On Thu, May 16, 2019 at 10:25 AM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
> The GPU can be used as a thermal cooling device, add an optional
> '#cooling-cells' property.
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> ---
> Changes in v2:
> - patch added to the series
> ---
> Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
> index 18a2cde2e5f3..61fd41a20f99 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
> @@ -37,6 +37,8 @@ Optional properties:
> - operating-points-v2 : Refer to Documentation/devicetree/bindings/opp/opp.txt
> for details.
>
> +- #cooling-cells: Refer to Documentation/devicetree/bindings/thermal/thermal.txt
> + for details.
>
> Example for a Mali-T760:
>
> @@ -51,6 +53,7 @@ gpu@ffa30000 {
> mali-supply = <&vdd_gpu>;
> operating-points-v2 = <&gpu_opp_table>;
> power-domains = <&power RK3288_PD_GPU>;
> + #cooling-cells = <2>;
> };
You will conflict with d5ff1adb3809 ("dt-bindings: gpu: mali-midgard:
Add resets property"), but it's easy to rebase. I'll leave it to
whoever is going to land this to decide if they would like you to
re-post or if they can handle resolving the conflict themselves.
+Kevin who appears to be the one who landed the conflicting commit.
With that:
Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>