RE: [PATCH] hv_sock: perf: Allow the socket buffer size options to influence the actual socket buffers

From: Dexuan Cui
Date: Thu May 16 2019 - 20:49:46 EST


> From: Sunil Muthuswamy <sunilmut@xxxxxxxxxxxxx>
> Sent: Thursday, May 16, 2019 5:17 PM
>
> Currently, the hv_sock buffer size is static and can't scale to the
> bandwidth requirements of the application. This change allows the
> applications to influence the socket buffer sizes using the SO_SNDBUF and
> the SO_RCVBUF socket options.
>
> Few interesting points to note:
> 1. Since the VMBUS does not allow a resize operation of the ring size, the
> socket buffer size option should be set prior to establishing the
> connection for it to take effect.
> 2. Setting the socket option comes with the cost of that much memory being
> reserved/allocated by the kernel, for the lifetime of the connection.

Reviewed-by: Dexuan Cui <decui@xxxxxxxxxxxxx>

The patch looks good to me. Thanks, Sunil!

Thanks,
-- Dexuan