Re: [PATCH v2] KVM: selftests: Compile code with warnings enabled

From: Vitaly Kuznetsov
Date: Fri May 17 2019 - 06:54:54 EST


Thomas Huth <thuth@xxxxxxxxxx> writes:

>
> x86_64/vmx_set_nested_state_test.c: In function
> âset_revision_id_for_vmcs12â:
> x86_64/vmx_set_nested_state_test.c:78:2: warning: dereferencing
> type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing]
> *(u32 *)(state->data) = vmcs12_revision;
>
> ... how do we want to handle such spots in the kvm selftest code?
> Compile with -fno-strict-aliasing? Or fix it with type-punning through
> unions?

These are tests, let's keep code simple. Casting my vote for the former
option)

--
Vitaly