Re: [PATCH v3 5/6] x86/MCE: Save MCA control bits that get set in hardware

[Borislav Petkov]

On Fri, May 17, 2019 at 07:49:10PM +0000, Ghannam, Yazen wrote:
> > @@ -1569,7 +1575,13 @@ static void __mcheck_cpu_init_clear_banks(void)
> > 
> >                 if (!b->init)
> >                         continue;
> > +
> > +               /* Check if any bits are implemented in h/w */
> >                 wrmsrl(msr_ops.ctl(i), b->ctl);
> > +               rdmsrl(msr_ops.ctl(i), msrval);
> > +
> > +               b->init = !!msrval;
> > +
> Just a minor nit, but can we group the comment, RDMSR, and check
> together? The WRMSR is part of normal operation and isn't tied to the
> check.

Of course it is - that's the "throw all 1s at it" part :)

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.