Re: [PATCH v5 1/6] drm: panfrost: add optional bus_clock

From: Rob Herring
Date: Fri May 17 2019 - 16:09:56 EST


On Fri, May 17, 2019 at 1:47 PM ClÃment PÃron <peron.clem@xxxxxxxxx> wrote:
>
> Allwinner H6 has an ARM Mali-T720 MP2 which required a bus_clock.
>
> Add an optional bus_clock at the init of the panfrost driver.
>
> Signed-off-by: ClÃment PÃron <peron.clem@xxxxxxxxx>
> ---
> drivers/gpu/drm/panfrost/panfrost_device.c | 25 +++++++++++++++++++++-
> drivers/gpu/drm/panfrost/panfrost_device.h | 1 +
> 2 files changed, 25 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c
> index 3b2bced1b015..8da6e612d384 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_device.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_device.c
> @@ -44,7 +44,8 @@ static int panfrost_clk_init(struct panfrost_device *pfdev)
>
> pfdev->clock = devm_clk_get(pfdev->dev, NULL);
> if (IS_ERR(pfdev->clock)) {
> - dev_err(pfdev->dev, "get clock failed %ld\n", PTR_ERR(pfdev->clock));
> + dev_err(pfdev->dev, "get clock failed %ld\n",
> + PTR_ERR(pfdev->clock));

Please drop this whitespace change.

> return PTR_ERR(pfdev->clock);
> }
>