Re: [PATCH] of_net: fix of_get_mac_address retval if compiled without CONFIG_OF

[Sergei Shtylyov]

Hello!

On 19.05.2019 15:18, Petr Åtetiar wrote:

> of_get_mac_address prior to commit d01f449c008a ("of_net: add NVMEM
> support to of_get_mac_address") could return only valid pointer or NULL,
> after this change it could return only valid pointer or ERR_PTR encoded
> error value, but I've forget to change the return value of

   It's either "I've forgotten" or just "I forgot".

> of_get_mac_address in case where the kernel is compiled without
> CONFIG_OF, so I'm doing so now.

   Well, better late... :-)

> Cc: Mirko Lindner <mlindner@xxxxxxxxxxx>
> Cc: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>
> Fixes: d01f449c008a ("of_net: add NVMEM support to of_get_mac_address")
> Reported-by: Octavio Alvarez <octallk1@xxxxxxxxxxxx>
> Signed-off-by: Petr Åtetiar <ynezz@xxxxxxx>
[...]

MBR, Sergei