Re: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes statement
From: Joe Perches
Date: Mon May 20 2019 - 09:37:17 EST
On Mon, 2019-05-20 at 13:16 +0000, Michal Kalderon wrote:
> > From: Joe Perches <joe@xxxxxxxxxxx>
> > Sent: Monday, May 20, 2019 3:57 PM
> > Subject: [EXT] Re: [PATCH] checkpatch: add test for empty line after Fixes
> > statement
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> > On Mon, 2019-05-20 at 15:42 +0300, Michal Kalderon wrote:
> > > Check that there is no empty line after a fixes statement
> >
> > why?
> >
> This comment is given a lot on the netdev and rdma mailing lists when patches are submitted with
> an empty line between Fixes: tag and SOB tags. Since "Fixes:" is just another tag and should be kept
> together with the other ones.
So test that all signature blocks and Fixes do not have
blank lines between them instead of just the "Fixes:" line.
And if there is some specific ordering required, perhaps a
test for that ordering should be added as well.