Re: [RFC PATCH 2/4] x86/ftrace: Fix use of flags in ftrace_replace_code()

From: Steven Rostedt
Date: Mon May 20 2019 - 09:46:39 EST


On Mon, 20 May 2019 09:13:20 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:


> > I haven't yet tested this patch on x86, but this looked wrong so sending
> > this as a RFC.
>
> This code has been through a bit of updates, and I need to go through
> and clean it up. I'll have to take a look and convert "int" to "bool"
> so that "enable" is not confusing.
>
> Thanks, I think I'll try to do a clean up first, and then this patch
> shouldn't "look wrong" after that.
>

I'm going to apply the attached two patches. There may be some
conflicts between yours here and these, but nothing that Linus can't
figure out. Do you feel more comfortable with this code, if these
patches are applied?

-- Steve