RE: [PATCH v4] tipc: fix modprobe tipc failed after switch order of device registration

[Jon Maloy]

Reviewed and tested. I found no problems with this.

Reviewed-by: Jon Maloy <jon.maloy@xxxxxxxxxxxx>


> -----Original Message-----
> From: netdev-owner@xxxxxxxxxxxxxxx <netdev-owner@xxxxxxxxxxxxxxx>
> On Behalf Of David Miller
> Sent: 20-May-19 13:46
> To: hujunwei4@xxxxxxxxxx
> Cc: Jon Maloy <jon.maloy@xxxxxxxxxxxx>; ying.xue@xxxxxxxxxxxxx;
> willemdebruijn.kernel@xxxxxxxxx; sfr@xxxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; tipc-discussion@xxxxxxxxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; mingfangsen@xxxxxxxxxx
> Subject: Re: [PATCH v4] tipc: fix modprobe tipc failed after switch order of
> device registration
> 
> From: hujunwei <hujunwei4@xxxxxxxxxx>
> Date: Mon, 20 May 2019 14:43:59 +0800
> 
> > From: Junwei Hu <hujunwei4@xxxxxxxxxx>
> >
> > Error message printed:
> > modprobe: ERROR: could not insert 'tipc': Address family not supported
> > by protocol.
> > when modprobe tipc after the following patch: switch order of device
> > registration, commit 7e27e8d6130c
> > ("tipc: switch order of device registration to fix a crash")
> >
> > Because sock_create_kern(net, AF_TIPC, ...) called by
> > tipc_topsrv_create_listener() in the initialization process of
> > tipc_init_net(), so tipc_socket_init() must be execute before that.
> > Meanwhile, tipc_net_id need to be initialized when sock_create()
> > called, and tipc_socket_init() is no need to be called for each namespace.
> >
> > I add a variable tipc_topsrv_net_ops, and split the
> > register_pernet_subsys() of tipc into two parts, and split
> > tipc_socket_init() with initialization of pernet params.
> >
> > By the way, I fixed resources rollback error when tipc_bcast_init()
> > failed in tipc_init_net().
> >
> > Fixes: 7e27e8d6130c ("tipc: switch order of device registration to fix
> > a crash")
> > Signed-off-by: Junwei Hu <hujunwei4@xxxxxxxxxx>
> > Reported-by: Wang Wang <wangwang2@xxxxxxxxxx>
> > Reported-by: syzbot+1e8114b61079bfe9cbc5@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Reviewed-by: Kang Zhou <zhoukang7@xxxxxxxxxx>
> > Reviewed-by: Suanming Mou <mousuanming@xxxxxxxxxx>
> 
> Applied.