Re: [PATCH net-next] vlan: Mark expected switch fall-through

From: David Miller
Date: Mon May 20 2019 - 14:41:45 EST


From: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>
Date: Mon, 20 May 2019 09:51:05 -0500

> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> net/8021q/vlan_dev.c: In function ʽvlan_dev_ioctlʼ:
> net/8021q/vlan_dev.c:374:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (!net_eq(dev_net(dev), &init_net))
> ^
> net/8021q/vlan_dev.c:376:2: note: here
> case SIOCGMIIPHY:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>

Also applied to 'net', thanks.