Re: [PATCH net-next] macvlan: Mark expected switch fall-through

From: Gustavo A. R. Silva
Date: Mon May 20 2019 - 14:52:07 EST




On 5/20/19 1:38 PM, David Miller wrote:
> From: "Gustavo A. R. Silva" <gustavo@xxxxxxxxxxxxxx>
> Date: Mon, 20 May 2019 09:44:49 -0500
>
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/net/macvlan.c: In function ʽmacvlan_do_ioctlʼ:
>> drivers/net/macvlan.c:839:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (!net_eq(dev_net(dev), &init_net))
>> ^
>> drivers/net/macvlan.c:841:2: note: here
>> case SIOCGHWTSTAMP:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@xxxxxxxxxxxxxx>
>
> I'll apply this to 'net' since it was introduced actually by arecent
> change.
>

OK, great. :)

Thank you.
--
Gsutavo