Re: [PATCH] staging: fieldbus: solve warning incorrect type dev_core.c

[Oscar Gomez Fuente]

Hi Sven,

Yes.

Oscar Gomez Fuente


Ãscar GÃmez Fuente
Electronic Engineer & Degree in Physical Sciences
Mobile: 659.28.97.90
Email: oscargomezf@xxxxxxxxx
Website: www.oscargomezf.com



On Mon, 20 May 2019 at 21:39, Sven Van Asbroeck <thesven73@xxxxxxxxx> wrote:
>
> On Mon, May 20, 2019 at 2:35 PM Sven Van Asbroeck <thesven73@xxxxxxxxx> wrote:
> >
> > Hi Oscar, thank you for your contribution! I have a question, see inline.
> >
> > On Fri, May 17, 2019 at 1:50 PM Oscar Gomez Fuente
> > <oscargomezf@xxxxxxxxx> wrote:
> > >
> > > These changes solve a warning realated to an incorrect type inilizer in the function
> > > fieldbus_poll.
> > >
>
> This warning was generated by sparse, right?
>
> $ make C=2 drivers/staging/fieldbus/
> <snip>
>   CHECK   drivers/staging/fieldbus/dev_core.c
> drivers/staging/fieldbus/dev_core.c:232:27: warning: incorrect type in
> initializer (different base types)
> drivers/staging/fieldbus/dev_core.c:232:27:    expected restricted
> __poll_t ( *poll )( ... )
> drivers/staging/fieldbus/dev_core.c:232:27:    got unsigned int (
> *<noident> )( ... )
> <snip>
>
> I will test your patch on actual h/w, probably tomorrow.
> I don't expect to see any problems.
>
> Sven