Re: [PATCH v2 3/3] ARM: dts: rockchip: Configure the GPU thermal zone for mickey

From: Doug Anderson
Date: Mon May 20 2019 - 19:31:58 EST


Hi,

On Mon, May 20, 2019 at 3:01 PM Matthias Kaehlcke <mka@xxxxxxxxxxxx> wrote:
>
> mickey crams a lot of hardware into a tiny package, which requires
> more aggressive thermal throttling than for devices with a larger
> footprint. Configure the GPU thermal zone to throttle the GPU
> progressively at temperatures >= 60ÂC. Heat dissipated by the
> CPUs also affects the GPU temperature, hence we cap the CPU
> frequency to 1.4 GHz for temperatures above 65ÂC. Further throttling
> of the CPUs may be performed by the CPU thermal zone.
>
> The configuration matches that of the downstream Chrome OS 3.14
> kernel, the 'official' kernel for mickey.
>
> Signed-off-by: Matthias Kaehlcke <mka@xxxxxxxxxxxx>
> ---
> Changes in v2:
> - specify all CPUs as cooling devices
> - s/downstram/downstream/ in commit message
>
> Note: this patch depends on "ARM: dts: rockchip: Add #cooling-cells
> entry for rk3288 GPU" (https://lore.kernel.org/patchwork/patch/1075005/)
> ---
> arch/arm/boot/dts/rk3288-veyron-mickey.dts | 67 ++++++++++++++++++++++
> 1 file changed, 67 insertions(+)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>