Re: [PATCH 1/8] net: qualcomm: rmnet: fix struct rmnet_map_header
From: Alex Elder
Date: Mon May 20 2019 - 22:32:55 EST
On 5/20/19 8:32 PM, Subash Abhinov Kasiviswanathan wrote:
>>
>> IfÂyouÂareÂtellingÂmeÂthatÂtheÂcommand/dataÂflagÂresidesÂatÂbit
>> 7ÂofÂtheÂfirstÂbyte,ÂIÂwillÂupdateÂtheÂfieldÂmasksÂinÂaÂlater
>> patchÂinÂthisÂseriesÂtoÂreflectÂthat.
>>
>
> HigherÂorderÂbitÂisÂCommandÂ/ÂData.
So what this means is that to get the command/data bit we use:
first_byte & 0x80
If that is correct I will remove this patch from the series and
will update the subsequent patches so bit 7 is the command bit,
bit 6 is reserved, and bits 0-5 are the pad length.
I will post a v2 of the series with these changes, and will
incorporate Bjorn's "Reviewed-by".
-Alex