Re: [PATCH v2 0/2] pinctrl: mediatek: mt8183: Add support for wake sources

From: Sean Wang
Date: Tue May 21 2019 - 06:16:02 EST


On Thu, May 16, 2019 at 4:56 AM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Wed, May 8, 2019 at 9:33 AM Nicolas Boichat <drinkcat@xxxxxxxxxxxx> wrote:
>
> > This adds support for wake sources in pinctrl-mtk-common-v2, and
> > pinctrl-mt8183. Without this patch, all interrupts that are left
> > enabled on suspend act as wake sources (and wake sources without
> > interrupt enabled do not).
> >
> > Changes since v1:
> > - Move changes from mtk-common-v2 to mtk-pinctrl-paris, as
> > recommended by Sean, to keep better separation between eint
> > and pinctrl-common features.
> >
> > Nicolas Boichat (2):
> > pinctrl: mediatek: Add pm_ops to pinctrl-paris
> > pinctrl: mediatek: mt8183: Add mtk_pinctrl_paris_pm_ops
>
> All seems to look fair to me, but I need some official ACK from
> Sean on these.
>

sure, it looks good to me and thanks for Nicolas' help

Acked-by: Sean Wang <sean.wang@xxxxxxxxxx>

> I see there is some discussion on a related patch set which
> also has two patches so I am a but confused how mature the
> two patch sets are? Are they at all related?
>
> Yours,
> Linus Walleij