Re: [PATCH v4 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state
From: Vinod Koul
Date: Tue May 21 2019 - 07:42:11 EST
On 13-05-19, 15:50, Sibi Sankar wrote:
> Remoteproc q6v5-mss calls set_performace_state with INT_MAX on
s/performace/performance
> rpmpd. This is currently ignored since it is greater than the
> max supported state. Fixup rpmpd state to max if the required
> state is greater than all the supported states.
>
> Fixes: 075d3db8d10d ("soc: qcom: rpmpd: Add support for get/set performance state")
>
> Reviewed-by: Marc Gonzalez <marc.w.gonzalez@xxxxxxx>
> Signed-off-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>
> ---
> drivers/soc/qcom/rpmpd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/rpmpd.c b/drivers/soc/qcom/rpmpd.c
> index 005326050c23..235d01870dd8 100644
> --- a/drivers/soc/qcom/rpmpd.c
> +++ b/drivers/soc/qcom/rpmpd.c
> @@ -226,7 +226,7 @@ static int rpmpd_set_performance(struct generic_pm_domain *domain,
> struct rpmpd *pd = domain_to_rpmpd(domain);
>
> if (state > MAX_RPMPD_STATE)
> - goto out;
> + state = MAX_RPMPD_STATE;
>
> mutex_lock(&rpmpd_lock);
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
--
~Vinod