Re: [PATCH] orangefs: remove redundant assignment to variable buffer_index
From: Dan Carpenter
Date: Tue May 21 2019 - 11:06:43 EST
On Thu, May 16, 2019 at 12:06:31PM -0400, Mike Marshall wrote:
> Hi Colin...
>
> Thanks for the patch. Before I initialized buffer_index, Dan Williams sent
> in a warning that a particular error path could try to use ibuffer_index
> uninitialized. I could induce the problem he described with one
> of the xfstests resulting in a crashed kernel. I will try to refactor
> the code to fix the problem some other way than initializing
> buffer_index in the declaration.
>
The only explanation I can think of is that you guys are discussing
different code. :P
regards,
dan carpenter