[PATCH perf/core] tools/perf/util/machine: Return NULL instead of null-terminating
From: Donald Yandt
Date: Tue May 21 2019 - 13:58:30 EST
Return NULL instead of null-terminating version char array when fgets fails due to end-of-file or error.
Signed-off-by: Donald Yandt <donald.yandt@xxxxxxxxx>
---
tools/perf/util/machine.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c
index 28a9541c4..6fd877220 100644
--- a/tools/perf/util/machine.c
+++ b/tools/perf/util/machine.c
@@ -1235,9 +1235,9 @@ static char *get_kernel_version(const char *root_dir)
return NULL;
tmp = fgets(version, sizeof(version), file);
- if (!tmp)
- *version = '\0';
fclose(file);
+ if (!tmp)
+ return NULL;
name = strstr(version, prefix);
if (!name)
--
2.20.1