Re: arm64 patch
From: Rasmus Villemoes
Date: Wed May 22 2019 - 02:24:11 EST
On 22/05/2019 07.42, Andrew Morton wrote:
> On Tue, 14 May 2019 20:31:58 -0700 Nathan Chancellor <natechancellor@xxxxxxxxx> wrote:
>
>> On Tue, May 14, 2019 at 04:16:19PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote:
>>> do we know if
>>> https://lkml.org/lkml/2019/4/29/743
>>> https://lkml.org/lkml/2019/4/29/747
>>> got picked up?
>>> I just saw akpm send a PR, but didn't get any emails related to those
>>> (maybe I'm not cc'ed).
>>>
>>> --
>>> Thanks,
>>> ~Nick Desaulniers
>>>
>>
>> It doesn't look like it according to -next.
>
> I don't normally do arm64 or powerpc things. And I usually take a pass
> if cc'ed on a fraction of a patch series.
>
> Anyway, if there's something you want me to do here, please send fresh
> patches at me?
>
So, this is of course already too late for 5.2. Since there were also
problems with old compilers for x86 [1], I think I'll try to change this
to an opt-in model (the arch says HAVE_..., but then actually choosing
DYNAMIC_DEBUG_RELATIVE_POINTERS is up to whoever does the .config, with
a warning in the help text that it may fail to compile/link depending on
toolchain).
Andrew, please drop the following five patches from your tree (sha1s as
per next-20190522):
f418571688c5 powerpc: select DYNAMIC_DEBUG_RELATIVE_POINTERS for PPC64
0dd95e972ef8 arm64: select DYNAMIC_DEBUG_RELATIVE_POINTERS
1a086a6f12ca x86_64: select DYNAMIC_DEBUG_RELATIVE_POINTERS
a6e9afb84c99 lib/dynamic_debug.c: add asm-generic implementation for
DYNAMIC_DEBUG_RELATIVE_POINTERS
e301d47f9756 lib/dynamic_debug.c: introduce
CONFIG_DYNAMIC_DEBUG_RELATIVE_POINTERS
Thanks,
Rasmus
[1]
https://lore.kernel.org/lkml/1afb0702-3cc5-ba4f-2bdd-604d9da2b846@xxxxxxxxxxxxxxxxxx/