Re: [PATCH v3 3/3] arm64: dts: meson: Add minimal support for Odroid-N2

[Neil Armstrong]

On 21/05/2019 18:11, Robin Murphy wrote:
> On 21/05/2019 16:19, Neil Armstrong wrote:
> [...]
>> +ÂÂÂÂÂÂÂ cpu100: cpu@100 {
>> +ÂÂÂÂÂÂÂÂÂÂÂ device_type = "cpu";
>> +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "arm,cortex-a73", "arm,armv8";
> 
> Nit: we've recently tried to eradicate "arm,armv8" as a fallback compatible for real CPUs (although I see there are still a couple of instances that have slipped through).

Thanks for pointing this, I'll remove it.

Neil

> 
> Robin.
> 
>> +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0x0 0x100>;
>> +ÂÂÂÂÂÂÂÂÂÂÂ enable-method = "psci";
>> +ÂÂÂÂÂÂÂÂÂÂÂ next-level-cache = <&l2>;
>> +ÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂ cpu101: cpu@101 {
>> +ÂÂÂÂÂÂÂÂÂÂÂ device_type = "cpu";
>> +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "arm,cortex-a73", "arm,armv8";
>> +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0x0 0x101>;
>> +ÂÂÂÂÂÂÂÂÂÂÂ enable-method = "psci";
>> +ÂÂÂÂÂÂÂÂÂÂÂ next-level-cache = <&l2>;
>> +ÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂ cpu102: cpu@102 {
>> +ÂÂÂÂÂÂÂÂÂÂÂ device_type = "cpu";
>> +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "arm,cortex-a73", "arm,armv8";
>> +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0x0 0x102>;
>> +ÂÂÂÂÂÂÂÂÂÂÂ enable-method = "psci";
>> +ÂÂÂÂÂÂÂÂÂÂÂ next-level-cache = <&l2>;
>> +ÂÂÂÂÂÂÂ };
>> +
>> +ÂÂÂÂÂÂÂ cpu103: cpu@103 {
>> +ÂÂÂÂÂÂÂÂÂÂÂ device_type = "cpu";
>> +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "arm,cortex-a73", "arm,armv8";
>> +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0x0 0x103>;
>> +ÂÂÂÂÂÂÂÂÂÂÂ enable-method = "psci";
>> +ÂÂÂÂÂÂÂÂÂÂÂ next-level-cache = <&l2>;
>> +ÂÂÂÂÂÂÂ };
>> +ÂÂÂ };
>> +};
>> +
>> +&clkc {
>> +ÂÂÂ compatible = "amlogic,g12b-clkc";
>> +};
>>