Re: [PATCH] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc

From: Bharath Vedartham
Date: Wed May 22 2019 - 11:59:47 EST


On Wed, May 22, 2019 at 04:48:33AM -0700, Joe Perches wrote:
> On Wed, 2019-05-22 at 15:23 +0530, Bharath Vedartham wrote:
> > Replace kmalloc + memcpy with kmemdup.
> > This was reported by coccinelle.
> []
> > diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c
> []
> > @@ -6001,13 +6001,12 @@ mpt_findImVolumes(MPT_ADAPTER *ioc)
> > if (mpt_config(ioc, &cfg) != 0)
> > goto out;
> >
> > - mem = kmalloc(iocpage2sz, GFP_KERNEL);
> > + mem = kmemdup((u8 *)pIoc2, iocpage2sz, GFP_KERNEL);
>
> You should remove the unnecessary cast here.
>
>
Yes! I will change this in v2.

Thanks
Bharath