Re: [PATCH v4 3/5] dt-bindings: watchdog: add Allwinner H6 r_watchdog

From: ClÃment PÃron
Date: Wed May 22 2019 - 12:18:21 EST


Hi Maxime,

On Wed, 22 May 2019 at 12:32, Maxime Ripard <maxime.ripard@xxxxxxxxxxx> wrote:
>
> On Tue, May 21, 2019 at 06:03:28PM +0200, ClÃment PÃron wrote:
> > Allwinner H6 has a second watchdog on the r-blocks which is
> > compatible with the A31.
> >
> > This commit add the H6 compatible for the r_watchdog.
> >
> > Signed-off-by: ClÃment PÃron <peron.clem@xxxxxxxxx>
>
> Unless you have some evidence that the two blocks are different, then
> you should just reuse the same one.

I have no evidence it's different nor identical, it's not documented
in the user manual.
I thought it would better to have separate bindings in case there is a
difference.
Than don't have and find later that we have to introduce one.

But as you prefer.

Regards,
ClÃment



>
> Maxime
>
> --
> Maxime Ripard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com