Re: [PATCH] crypto: talitos - fix skcipher failure due to wrong output IV

From: Herbert Xu
Date: Thu May 23 2019 - 02:54:28 EST


On Wed, May 15, 2019 at 12:29:03PM +0000, Christophe Leroy wrote:
> Selftests report the following:
>
> [ 2.984845] alg: skcipher: cbc-aes-talitos encryption test failed (wrong output IV) on test vector 0, cfg="in-place"
> [ 2.995377] 00000000: 3d af ba 42 9d 9e b4 30 b4 22 da 80 2c 9f ac 41
> [ 3.032673] alg: skcipher: cbc-des-talitos encryption test failed (wrong output IV) on test vector 0, cfg="in-place"
> [ 3.043185] 00000000: fe dc ba 98 76 54 32 10
> [ 3.063238] alg: skcipher: cbc-3des-talitos encryption test failed (wrong output IV) on test vector 0, cfg="in-place"
> [ 3.073818] 00000000: 7d 33 88 93 0f 93 b2 42
>
> This above dumps show that the actual output IV is indeed the input IV.
> This is due to the IV not being copied back into the request.
>
> This patch fixes that.
>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> ---
> drivers/crypto/talitos.c | 4 ++++
> 1 file changed, 4 insertions(+)

Patch applied. Thanks.
--
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt