Re: [PATCH V3] hsr: fix don't prune the master node from the node_db

[Sergei Shtylyov]

Hello!

On 23.05.2019 10:02, Andreas Oetken wrote:

> Don't prune master node in the hsr_prune_nodes function.
> Neither time_in[HSR_PT_SLAVE_A], nor time_in[HSR_PT_SLAVE_B],
> will ever be updated by hsr_register_frame_in for the master port.
> Thus the master node will be repeatedly pruned leading to
> repeated packet loss.
> This bug never appeared because the hsr_prune_nodes function
> was only called once. Since commit 5150b45fd355
> ("net: hsr: Fix node prune function for forget time expiry") this issue
> is fixed unvealing the issue described above.
           ^^^^^^^^^
   My spellchecker trips on this word. I think it should be either 
"unveiling" or "revealing"...

>  Fixes: 5150b45fd355 ("net: hsr: Fix node prune function for forget time expiry")
> Signed-off-by: Andreas Oetken <andreas.oetken@xxxxxxxxxxx>
> Tested-by: Murali Karicheri <m-karicheri2@xxxxxx>
[...]

MBR, Sergei