Re: [PATCH 2/3] firmware: add offset to request_firmware_into_buf

[Scott Branden]

Hi Greg,

On 2019-05-22 10:52 p.m., Greg Kroah-Hartman wrote:
> On Wed, May 22, 2019 at 07:51:12PM -0700, Scott Branden wrote:
> > Add offset to request_firmware_into_buf to allow for portions
> > of firmware file to be read into a buffer.  Necessary where firmware
> > needs to be loaded in portions from file in memory constrained systems.
> >
> > Signed-off-by: Scott Branden <scott.branden@xxxxxxxxxxxx>
> > ---
> >   drivers/base/firmware_loader/firmware.h |  5 +++
> >   drivers/base/firmware_loader/main.c     | 49 +++++++++++++++++--------
> >   include/linux/firmware.h                |  8 +++-
> >   3 files changed, 45 insertions(+), 17 deletions(-)
> No new firmware test for this new option?  How do we know it even works?

I was unaware there are existing firmware tests. Please let me know 
where these tests exists and I can add a test for this new option.

We have tested this with a new driver in development which requires the 
firmware file to be read in portions into memory. I can add my 
tested-by and others to the commit message if desired.

> :)
>
> thanks,
>
> greg k-h

Regards,

Scott