Re: [PATCH] dt-bindings: thermal: Make cooling-maps property optional
From: Eduardo Valentin
Date: Thu May 23 2019 - 22:53:19 EST
On Wed, May 15, 2019 at 05:36:47PM +0800, Yuantian Tang wrote:
> There may be no cooling device on system, or there are no enough
> cooling devices for each thermal zone in multiple thermal zone
> cases since cooling devices can't be shared.
> So make this property optional to remove such limitations.
Yeah, I am not sure that is enough reason to make this property
optional. Let me maybe ask you why do you care creating a thermal
zone if your control has no actions? Or rather, why bothering
setting up a control that has no actuators?
>
> Signed-off-by: Yuantian Tang <andy.tang@xxxxxxx>
> ---
> .../devicetree/bindings/thermal/thermal.txt | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index ca14ba9..694e834 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -142,11 +142,11 @@ Required properties:
> - trips: A sub-node which is a container of only trip point nodes
> Type: sub-node required to describe the thermal zone.
>
> +
> +Optional property:
> - cooling-maps: A sub-node which is a container of only cooling device
> Type: sub-node map nodes, used to describe the relation between trips
> and cooling devices.
> -
> -Optional property:
> - coefficients: An array of integers (one signed cell) containing
> Type: array coefficients to compose a linear relation between
> Elem size: one cell the sensors listed in the thermal-sensors property.
> --
> 1.7.1
>