Re: [PATCH 2/2] auxdisplay/ht16k33.c: Convert to use vm_map_pages_zero()
From: Souptick Joarder
Date: Fri May 24 2019 - 02:13:55 EST
On Thu, May 23, 2019 at 6:53 PM Miguel Ojeda
> On Mon, May 20, 2019 at 5:26 PM Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote:
> > While using mmap, the incorrect value of length and vm_pgoff are
> > ignored and this driver go ahead with mapping fbdev.buffer
> > to user vma.
> Typos: values*, goes* (same for the other patch)
Ok, will add it into v2.
> > Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
> > "fix" these drivers to behave according to the normal vm_pgoff
> > offsetting simply by removing the _zero suffix on the function name
> > and if that causes regressions, it gives us an easy way to revert.
> Would it be possible to add a "Link:" to where these new functions are
> discussed/used (maybe a lore.kernel.org link?)?
This might be helpful.
> Thanks for the patch!