Re: [PATCH] gpio: fix gpio-adp5588 build errors

[Linus Walleij]

On Fri, May 24, 2019 at 12:00 AM Randy Dunlap <rdunlap@xxxxxxxxxxxxx> wrote:

> From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
>
> The gpio-adp5588 driver uses interfaces that are provided by
> GPIOLIB_IRQCHIP, so select that symbol in its Kconfig entry.
>
> Fixes these build errors:
>
> ../drivers/gpio/gpio-adp5588.c: In function âadp5588_irq_handlerâ:
> ../drivers/gpio/gpio-adp5588.c:266:26: error: âstruct gpio_chipâ has no member named âirqâ
>             dev->gpio_chip.irq.domain, gpio));
>                           ^
> ../drivers/gpio/gpio-adp5588.c: In function âadp5588_irq_setupâ:
> ../drivers/gpio/gpio-adp5588.c:298:2: error: implicit declaration of function âgpiochip_irqchip_add_nestedâ [-Werror=implicit-function-declaration]
>   ret = gpiochip_irqchip_add_nested(&dev->gpio_chip,
>   ^
> ../drivers/gpio/gpio-adp5588.c:307:2: error: implicit declaration of function âgpiochip_set_nested_irqchipâ [-Werror=implicit-function-declaration]
>   gpiochip_set_nested_irqchip(&dev->gpio_chip,
>   ^
>
> Fixes: 459773ae8dbb ("gpio: adp5588-gpio: support interrupt controller")
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
> Cc: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx

Patch applied for fixes.

Yours,
Linus Walleij