Re: [PATCH] dt-bindings: gpio: Convert Arm PL061 to json-schema

From: Linus Walleij
Date: Fri May 24 2019 - 07:41:30 EST

On Tue, May 14, 2019 at 2:50 AM Rob Herring <robh@xxxxxxxxxx> wrote:

> Convert the Arm PL061 GPIO controller binding to json-schema format.
> As I'm the author for all but the gpio-ranges line, make the schema dual
> GPL/BSD license.
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Patch applied. As you know I am already a big fan of this scheme.

> This warns on a few platforms missing clocks, interrupt-controller
> and/or #interrupt-cells. We could not make those required, but really
> they should be IMO. OTOH, it's platforms like Spear and Calxeda which
> aren't too active, so I don't know that we want to fix them.

What works for you works for me.

We could add dummy fixed clocks in the DTS files if
we wanted I suppose. The #interrupt-cells and interrupt-controller
things we can just fix, but I wonder what the maintainers of these
platforms are up to? Isn't Calxeda yours, and could Viresh fix
up the SPEAr?

Linus Walleij