Re: [PATCH V2 4/9] genirq/timings: Use the min kernel macro

From: Andy Shevchenko
Date: Fri May 24 2019 - 10:00:47 EST


On Fri, May 24, 2019 at 01:16:10PM +0200, Daniel Lezcano wrote:
> The' min' is available as a kernel macro. Use it instead of writing
> the same code.

While it's technically correct...

> /*
> * 'count' will depends if the circular buffer wrapped or not
> */
> - count = irqs->count < IRQ_TIMINGS_SIZE ?
> - irqs->count : IRQ_TIMINGS_SIZE;
> + count = min_t(int, irqs->count, IRQ_TIMINGS_SIZE);
>
> start = irqs->count < IRQ_TIMINGS_SIZE ?
> 0 : (irqs->count & IRQ_TIMINGS_MASK);

...looking to the context I would leave as is to have a pattern.

--
With Best Regards,
Andy Shevchenko