Re: [PATCH v2 5/5] net: dsa: add support for mv88e6250

From: Vivien Didelot
Date: Fri May 24 2019 - 14:14:25 EST


Hi Rasmus,

On Fri, 24 May 2019 09:00:31 +0000, Rasmus Villemoes <rasmus.villemoes@xxxxxxxxx> wrote:
> This is a very rough attempt at adding support for the Marvell
> 88E6250. The _info and _ops structures are based on those for 6240 (as
> I have data sheets for both the 6240 and 6250), fixing the things that
> I have determined to be different for the two chips - but some things
> are almost certain to still be wrong.

The idea is that for things that you're not certain about, simply
don't add the corresponding ops. The driver would simply return
-EOPNOTSUPP for the related features (if it doesn't behave like this,
we must fix this.)


Thanks,
Vivien