Re: [PATCH][next] drm/i915/gtt: set err to -ENOMEM on memory allocation failure

From: Chris Wilson
Date: Fri May 24 2019 - 17:48:20 EST


Quoting Colin King (2019-05-24 22:26:27)
> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Currently when the allocation of ppgtt->work fails the error return
> path via err_free returns an uninitialized value in err. Fix this
> by setting err to the appropriate error return of -ENOMEM.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
> Fixes: d3622099c76f ("drm/i915/gtt: Always acquire struct_mutex for gen6_ppgtt_cleanup")
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Saw that last night but got distracted by the panic-on-boot...
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
-Chris