[PATCH 1/1] io_uring: Fix __io_uring_register() false success

From: Pavel Begunkov (Silence)
Date: Sun May 26 2019 - 05:39:12 EST


From: Pavel Begunkov <asml.silence@xxxxxxxxx>

If io_copy_iov() fails, it will break the loop and report success,
albeit partially completed operation.

Signed-off-by: Pavel Begunkov <asml.silence@xxxxxxxxx>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/io_uring.c b/fs/io_uring.c
index 310f8d17c53e..0fbb486a320e 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2616,7 +2616,7 @@ static int io_sqe_buffer_register(struct io_ring_ctx *ctx, void __user *arg,

ret = io_copy_iov(ctx, &iov, arg, i);
if (ret)
- break;
+ goto err;

/*
* Don't impose further limits on the size and buffer
--
2.21.0